Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002073Core InformActivitiespublic2018-09-07 00:552018-09-11 01:48
ReporterEleas 
Assigned To 
PrioritynormalSeveritycosmeticReproducibilityalways
StatusnewResolutionopen 
Platformx86OSWindowsOS Version7
Product Version6M62 
Target VersionFixed in Version 
Summary0002073: Both examine containers and examine supporters rules inconsistent when contents are concealed
DescriptionWhen a container or supporter holds nothing but concealed things, a spurious message ("In [the container] is nothing.") is printed on examination.
Minimal Source Text To Reproduce
a box is a kind of container. some mud is a kind of thing.
some mud is in every box.

box1, box2, box3, box4 are boxes.
The description of the box1 is "Papery."
The description of the box3 is "Papery."

every box is here.
Rule for deciding the concealed possessions of box3: yes.
Rule for deciding the concealed possessions of box4: yes.

test me with "x box1 / x box2 / x box3 / x box4".
Additional InformationSuggested fix:

Carry out examining (this is the tweaked examine containers rule):
	if the noun is a container:
		if the noun is open or the noun is transparent and the noun holds a not concealed thing:
			if something described which is not scenery is in the noun and something which
				is not the player is in the noun:
				say "In [the noun] " (A);
				list the contents of the noun, as a sentence, tersely, not listing
					concealed items, prefacing with is/are;
				say ".";
				now examine text printed is true;
			otherwise if examine text printed is false:
				if the player is in the noun:
					make no decision;
				say "[The noun] [are] empty." (B);
				now examine text printed is true.


and

Carry out examining (this is the tweaked examine supporters rule):
	if the noun is a supporter and the noun supports a not concealed thing:
		if something described which is not scenery is on the noun and something which is
			not the player is on the noun:
			say "On [the noun] " (A);
			list the contents of the noun, as a sentence, tersely, not listing
				concealed items, prefacing with is/are, including contents,
				giving brief inventory information;
			say ".";
			now examine text printed is true.
TagsNo tags attached.
Effect(serious/mild) Game compiles but misbehaves
Attached Files

- Relationships

-  Notes
(0004802)
Eleas (reporter)
2018-09-07 02:55
edited on: 2018-09-07 03:15

Another instance of this bug is found in the you-can-also-see rule (evidenced by starting the game with the player inside box3).

Also, the logical precedence of my tweak to the examine containers rule is unclear. That probably ought to be simplified:

Carry out examining (this is the examine containers rule):
	if the noun is a container and an unconcealed thing is in the noun:
		if the noun is open or the noun is transparent:
			if something described which is not scenery is in the noun and something which
				is not the player is in the noun:
				say "In [the noun] " (A);
				list the contents of the noun, as a sentence, tersely, not listing
					concealed items, prefacing with is/are;
				say ".";
				now examine text printed is true;
			otherwise if examine text printed is false:
				if the player is in the noun:
					make no decision;
				say "[The noun] [are] empty." (B);
				now examine text printed is true.


(0004803)
zarf (developer)
2018-09-08 21:03
edited on: 2018-09-08 21:08

Note: this is about the I7 "deciding the concealed possessions" rulebook, not the I6 "concealed" ("described") property.

(The proposed fix tests "described", but only because the existing Standard Rules code does. This confused me briefly.)

(0004804)
zarf (developer)
2018-09-08 21:07

As to your fix: I think that if all the contents are concealed, it should fall into the existing "[The noun] [are] empty" case. That is, undescribed and concealed objects should be equivalent in the logic.
(0004805)
Eleas (reporter)
2018-09-10 01:09
edited on: 2018-09-10 01:48

I'm slightly confused. When a container is described but empty, the "[The noun] [are] empty" case does not trigger. Is that behavior as intended? If so, would

Carry out examining (this is the examine containers rule):
	if the noun is a container:
		if the noun is open or the noun is transparent:
			if something described which is not scenery is in the noun and something unconcealed which
				is not the player is in the noun:
				say "In [the noun] " (A);
				list the contents of the noun, as a sentence, tersely, not listing
					concealed items, prefacing with is/are;
				say ".";
				now examine text printed is true;
			otherwise if examine text printed is false:
				if the player is in the noun:
					make no decision;
				say "[The noun] [are] empty." (B);
				now examine text printed is true.


do the trick?

(0004806)
zarf (developer)
2018-09-10 20:37

I was thinking of

if something for-real-visible is in the noun and something which is not the player is in the noun:

...where "for-real-visible" is true if the object is described and unconcealed and not-scenery.
(0004808)
Eleas (reporter)
2018-09-11 01:48

Fair enough. Anyway, bug confirmed?

- Issue History
Date Modified Username Field Change
2018-09-07 00:55 Eleas New Issue
2018-09-07 02:55 Eleas Note Added: 0004802
2018-09-07 02:57 Eleas Note Edited: 0004802 View Revisions
2018-09-07 03:15 Eleas Note Edited: 0004802 View Revisions
2018-09-08 21:03 zarf Note Added: 0004803
2018-09-08 21:07 zarf Note Added: 0004804
2018-09-08 21:08 zarf Note Edited: 0004803 View Revisions
2018-09-10 01:09 Eleas Note Added: 0004805
2018-09-10 01:16 Eleas Note Edited: 0004805 View Revisions
2018-09-10 01:48 Eleas Note Edited: 0004805 View Revisions
2018-09-10 20:37 zarf Note Added: 0004806
2018-09-11 01:48 Eleas Note Added: 0004808


Copyright © 2000 - 2010 MantisBT Group
Powered by Mantis Bugtracker