MantisBT - Core Inform | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0000757 | Core Inform | Understanding | public | 2011-09-22 02:45 | 2014-05-07 07:34 |
Reporter | Ron Newcomb | ||||
Assigned To | graham | ||||
Priority | normal | Severity | cosmetic | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | PPC | OS | Mac OS X | OS Version | 10.4 |
Product Version | 6G60 | ||||
Target Version | Fixed in Version | 6L02 | |||
Effect | (cosmetic) Error message is badly worded | ||||
Submitter | |||||
Summary | 0000757: duplicated code in Parser.i6t | ||||
Description | The following appears in Parser.i6t, in "Parser Letter E": for (i=0 : i<32 : i++) { line_token-->i = ENDIT_TOKEN; line_ttype-->i = ELEMENTARY_TT; line_tdata-->i = ENDIT_TOKEN; } ! Unpack the syntax line from Inform format into three arrays; ensure that ! the sequence of tokens ends in an ENDIT_TOKEN. line_address = UnpackGrammarLine(line_address); However, inside the UnpackGrammarLine function is this: [ UnpackGrammarLine line_address i size; for (i=0 : i<32 : i++) { line_token-->i = ENDIT_TOKEN; line_ttype-->i = ELEMENTARY_TT; line_tdata-->i = ENDIT_TOKEN; } The same paragraph of code is reproduced exactly. Recommend striking the outer paragraph, to shorten "Parser Letter E", and in case someone calls UnpackGrammarLine from a different location for whatever reason. | ||||
Minimal Source Text To Reproduce | |||||
Additional Information | |||||
Tags | wrongeffect | ||||
Relationships | |||||
Attached Files | |||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2011-09-22 02:45 | Ron Newcomb | New Issue | |||
2011-09-22 11:39 | EmacsUser | Tag Attached: wrongeffect | |||
2011-09-22 11:40 | EmacsUser | Status | new => confirmed | ||
2011-09-22 11:41 | EmacsUser | Category | Source text and punctuation => Understanding | ||
2011-10-15 01:05 | graham | Note Added: 0001359 | |||
2011-10-15 01:05 | graham | Status | confirmed => resolved | ||
2011-10-15 01:05 | graham | Resolution | open => fixed | ||
2011-10-15 01:05 | graham | Assigned To | => graham | ||
2014-05-07 07:34 | jmcgrew | Fixed in Version | => 6L02 | ||
2014-05-07 07:34 | jmcgrew | Status | resolved => closed |
Notes | |||||
|
|||||
|
|