MantisBT - Core Inform
View Issue Details
0000757Core InformUnderstandingpublic2011-09-22 02:452014-05-07 07:34
Ron Newcomb 
graham 
normalcosmeticalways
closedfixed 
PPCMac OS X10.4
6G60 
6L02 
(cosmetic) Error message is badly worded
0000757: duplicated code in Parser.i6t
The following appears in Parser.i6t, in "Parser Letter E":

        for (i=0 : i<32 : i++) {
            line_token-->i = ENDIT_TOKEN;
            line_ttype-->i = ELEMENTARY_TT;
            line_tdata-->i = ENDIT_TOKEN;
        }

        ! Unpack the syntax line from Inform format into three arrays; ensure that
        ! the sequence of tokens ends in an ENDIT_TOKEN.

        line_address = UnpackGrammarLine(line_address);


However, inside the UnpackGrammarLine function is this:


[ UnpackGrammarLine line_address i size;
    for (i=0 : i<32 : i++) {
        line_token-->i = ENDIT_TOKEN;
        line_ttype-->i = ELEMENTARY_TT;
        line_tdata-->i = ENDIT_TOKEN;
    }


The same paragraph of code is reproduced exactly. Recommend striking the outer paragraph, to shorten "Parser Letter E", and in case someone calls UnpackGrammarLine from a different location for whatever reason.
wrongeffect
Issue History
2011-09-22 02:45Ron NewcombNew Issue
2011-09-22 11:39EmacsUserTag Attached: wrongeffect
2011-09-22 11:40EmacsUserStatusnew => confirmed
2011-09-22 11:41EmacsUserCategorySource text and punctuation => Understanding
2011-10-15 01:05grahamNote Added: 0001359
2011-10-15 01:05grahamStatusconfirmed => resolved
2011-10-15 01:05grahamResolutionopen => fixed
2011-10-15 01:05grahamAssigned To => graham
2014-05-07 07:34jmcgrewFixed in Version => 6L02
2014-05-07 07:34jmcgrewStatusresolved => closed

Notes
(0001359)
graham   
2011-10-15 01:05   
Agreed. I've removed the code from E.